filechooser: set _handle_selection as attribute #570
+5
−47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
_handle_selection was defined as a placeholder for returning the
selection from the activity result. It was used as a fallback when
"on_selection" was not provided.
There is a side effect by doing this: when "on_selection" is not
defined, the self._handle_selection attribute overwrites the
_handle_selection method. As an example, the following code will print
"True", which is practically the same thing that kwargs.pop() does if
the second argument provided to it is None:
```
def _handle_selection(selection):
return selection
kwargs = {}
_handle_selection = kwargs.pop("on_selection", _handle_selection)
print(_handle_selection is None)
```
The reason I'm not using the second argument of kwargs.pop() as None in
this commit is because I think it's correct to raise a KeyError when
"on_selection" is not defined. Given that this is a file chooser
implementation, it's necessary to have a callback when a file is chosen
by the user, otherwise an error should be raised.
The solution is to let _handle_selection as an attribute and remove the
static method. This way _handle_selection is not overwritten and a
KeyError exception is be raised if "on_selection" is not provided.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
_handle_selectionwas defined as a placeholder for returning theselection from the activity result. It was used as a fallback when
on_selectionwas not provided.There's a side effect by doing this: when
on_selectionis not defined,the
self._handle_selectionattribute overwrites the_handle_selectionmethod. Given that this is a file chooserimplementation, I think it's necessary to have a callback when a file is
chosen by the user. With the current implementation, if the user does
not pass an
on_selectioncallback, no error is raised.The solution is to let
_handle_selectionas an attribute and removethe static method. This way it is not overwritten and a
KeyErrorexception is raised if
on_selectionis not provided.