Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

962 macos windows for zim opening #1030

Merged
merged 4 commits into from
Nov 21, 2024
Merged

Conversation

BPerlakiH
Copy link
Collaborator

Fixes: #962

@codecov-commenter
Copy link

codecov-commenter commented Nov 21, 2024

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 38.99%. Comparing base (5715eb7) to head (d4b80de).

Files with missing lines Patch % Lines
App/App_macOS.swift 0.00% 2 Missing ⚠️
ViewModel/BrowserViewModel.swift 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1030      +/-   ##
==========================================
+ Coverage   37.95%   38.99%   +1.04%     
==========================================
  Files         119      119              
  Lines        6955     6959       +4     
==========================================
+ Hits         2640     2714      +74     
+ Misses       4315     4245      -70     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Copy link
Member

@rgaudin rgaudin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rgaudin rgaudin merged commit 790b3ee into main Nov 21, 2024
4 checks passed
@rgaudin rgaudin deleted the 962-macos-windows-for-zim-opening branch November 21, 2024 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[REGRESSION] Opening app with ZIM doesnt open ZIM
4 participants