Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better Kiwix Server taskbar home button max-width #1088

Merged
merged 1 commit into from
May 20, 2024

Conversation

kelson42
Copy link
Collaborator

@kelson42 kelson42 commented May 19, 2024

Fixes #1084

I have increase the max-width of the Kiwix Server Home button to 30ch. Even if 30ch does not mean 30 characters, this is more or less the maximum width. It might happen that make it even a bit bigger in the future, but I didn't wanted to take too much risk to generate a regression of some kind.

Copy link

codecov bot commented May 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 40.93%. Comparing base (7366938) to head (6ee0911).
Report is 42 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1088   +/-   ##
=======================================
  Coverage   40.93%   40.93%           
=======================================
  Files          58       58           
  Lines        4204     4204           
  Branches     2307     2307           
=======================================
  Hits         1721     1721           
  Misses       1015     1015           
  Partials     1468     1468           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kelson42 kelson42 merged commit 4fe4a88 into main May 20, 2024
16 checks passed
@kelson42 kelson42 deleted the better-kiwix-server-home-buttom-width branch May 20, 2024 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Kiwix Server viewer „home“ button is most of he time not big enough
2 participants