-
-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: macOS port #24
base: devel
Are you sure you want to change the base?
WIP: macOS port #24
Conversation
- Fixed some of the struct declaration to comply with clang - Added libstlink.a which has been compiled on macos 13.5.2 (Ventura) for apple silicon - Added libspdlog.a fetched from homebrew
if GLFW is only used by imgui and implot, then dropping GLFW and using the metal backend provided in imgui shall be possible. |
The current main branch (352e8f4 builds on OS X only if I comment out all the stuff related to JLink - since there's no library supplied for the JLink on OS X. After that it builds and produces an executable which fails with the following error:
and then just hangs indefinitely. A few questions:
Is it still the case that there is the stlink library only for apple silicon? Should I add one for intel? It seems most of the changes contained in this PR needed to make things compile on apple are already integrated? On the other hand the addition of JLink support seems to have broken the apple compilation again. Can we make JLink an compile-time option? |
Hey! Thanks for the interest in the topic!
It seems the x86 version is in the repo already, however i'm not sure if its working.
I think so - there might be some more changes needed to make it run though. We sure can add the Jlink support - would you like to undertake this task? If so we could connect in some different way to discuss the plan ;) |
Hey and thanks for your reply!
I'd like to give it a shot - I can use MCUViewer on my linux boxes or via Parallels, so its not urgent, but it would be cool to get it running on the Mac which I use most.
My approach was actually to make the JLink optional, so we don't have to include it in Mac. I will do a quick search and see if the same lib is available on Mac, and if its license would allow us to distribute it. If so, I'm happy to give it a try to add it. I'm happy to connect and have a chat about it, let me know if you have a preferred way? I'm pretty busy at the moment, travelling all next week, so any time after the 18.10 would work for me. |
The jlink libraries come with the J-Link Software and Documentation pack for mac: libjlinkarm.dylib |
Great! Let's meet on a call after 18.10 then :) I'll write a private message so that we don't spam here. Could you give me your email address? I cannot see any contact info in the Github profile. |
I created a fork (avangerp/MCUViewer-macos) and replaced the OpenGL backend with the Metal backend from imgui. I did the build for x86_64 using Rosetta 2 on my M2 Macbook because I had trouble compiling the stlink library for arm64. I commented out all the jlink support because I saw the discussion in here and I don't have a jlink device to test/debug. The build completes, tests pass, and I haven't had any issues using the ui. I am not sure what it would look like to get the other backend support merged in here, but I am open to discussing and helping. |
Thank you very much for the work you've done! I will need some time to go through the changes, and maybe I'll be able to also use actions for creating the MacOS builds. Anyway I will most probably do it after the upcoming mid-December release ;) |
wip
App compiles but fails to create a window in Gui::mainThread() when invoking glfwCreateWindow see more details in #21