Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added the repo serving-progressive-rollot #211

Merged
merged 1 commit into from
Sep 25, 2023
Merged

Added the repo serving-progressive-rollot #211

merged 1 commit into from
Sep 25, 2023

Conversation

houshengbo
Copy link
Contributor

@houshengbo houshengbo commented Sep 25, 2023 •
edited
Loading

Which issue(s) this PR fixes:

Fixes: knative/community#1434

@knative-prow knative-prow bot requested review from cardil and krsna-m September 25, 2023 15:16
@knative-prow knative-prow bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Sep 25, 2023
upodroid
upodroid approved these changes Sep 25, 2023
View reviewed changes
Copy link
Member

@upodroid upodroid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Sep 25, 2023
@knative-prow
Copy link

knative-prow bot commented Sep 25, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: houshengbo, upodroid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 25, 2023
@knative-prow knative-prow bot merged commit 55fd4c3 into knative:main Sep 25, 2023
12 checks passed
@knative-prow
Copy link

knative-prow bot commented Sep 25, 2023

@houshengbo: Updated the job-config configmap in namespace default at cluster default using the following files:

  • key serving-progressive-rollout-main.gen.yaml using file prow/jobs/generated/knative-extensions/serving-progressive-rollout-main.gen.yaml

In response to this:

Which issue(s) this PR fixes:

Fixes: knative/community#1434

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@skonto skonto mentioned this pull request May 21, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@upodroid upodroid upodroid approved these changes

@cardil cardil Awaiting requested review from cardil

@krsna-m krsna-m Awaiting requested review from krsna-m

Assignees

@upodroid upodroid

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

New Repo: serving-progressive-rollout
2 participants
@houshengbo @upodroid