Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Loom and KEDA tests on demand tests #215

Merged
merged 1 commit into from
Sep 27, 2023
Merged

Make Loom and KEDA tests on demand tests #215

merged 1 commit into from
Sep 27, 2023

Conversation

pierDipi
Copy link
Member

These 2 jobs don't need to run every time, devs can trigger them when it's actually needed.

@pierDipi
Make Loom and KEDA tests on demand tests
9f1a467 
These 2 jobs don't need to run every time, devs can trigger them
when it's actually needed.

Signed-off-by: Pierangelo Di Pilato <[email protected]>
@knative-prow knative-prow bot requested review from cardil and krsna-m September 26, 2023 06:53
@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 26, 2023
@pierDipi
Copy link
Member Author

/cc @Cali0707 @debasishbsws

@knative-prow knative-prow bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Sep 26, 2023
@krsna-m
Copy link
Contributor

krsna-m commented Sep 26, 2023

/lgtm
/hold for the reviewers called out

@knative-prow knative-prow bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 26, 2023
@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Sep 26, 2023
Cali0707
Cali0707 approved these changes Sep 26, 2023
View reviewed changes
Copy link
Member

@Cali0707 Cali0707 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@knative-prow
Copy link

knative-prow bot commented Sep 26, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Cali0707, pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@pierDipi
Copy link
Member Author

/unhold

@knative-prow knative-prow bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 27, 2023
@knative-prow knative-prow bot merged commit ccb2a18 into knative:main Sep 27, 2023
12 checks passed
@knative-prow
Copy link

knative-prow bot commented Sep 27, 2023

@pierDipi: Updated the job-config configmap in namespace default at cluster default using the following files:

  • key eventing-kafka-broker-main.gen.yaml using file prow/jobs/generated/knative-extensions/eventing-kafka-broker-main.gen.yaml

In response to this:

These 2 jobs don't need to run every time, devs can trigger them when it's actually needed.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Cali0707 Cali0707 Cali0707 approved these changes

@cardil cardil Awaiting requested review from cardil

@krsna-m krsna-m Awaiting requested review from krsna-m

@debasishbsws debasishbsws Awaiting requested review from debasishbsws

Assignees

@Cali0707 Cali0707

@krsna-m krsna-m

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pierDipi @krsna-m @Cali0707