Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ppc64le specific changes added to prow config #216

Merged
merged 2 commits into from
Sep 27, 2023
Merged

ppc64le specific changes added to prow config #216

merged 2 commits into from
Sep 27, 2023

Conversation

valen-mascarenhas14
Copy link
Contributor

Signed-off-by: Valen Mascarenhas [email protected]

Which issue(s) this PR fixes:

Fixes

ppc64le specific changes added to prow config to support the new changes in the upstream ci repo

@knative-prow knative-prow bot requested review from mgencur and psschwei September 26, 2023 09:00
@knative-prow
Copy link

knative-prow bot commented Sep 26, 2023

Hi @valen-mascarenhas14. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow knative-prow bot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 26, 2023
@cardil
Copy link
Contributor

cardil commented Sep 26, 2023

/ok-to-test

@knative-prow knative-prow bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 26, 2023
cardil
cardil reviewed Sep 26, 2023
View reviewed changes
Copy link
Contributor

@cardil cardil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From where is this change coming from? I mean, there are some s390x clusters dedicated for upstream Knative?

prow/jobs_config/knative-extensions/kn-plugin-event.yaml Outdated Show resolved Hide resolved
@valen-mascarenhas14
Copy link
Contributor Author

@cardil Have made the necessary changes as requested by you

@krsna-m
Copy link
Contributor

krsna-m commented Sep 26, 2023

This is touching jobs across many different teams... I would like to see a +1 from at least serving or eventing that this is not disrupting them any.

@krsna-m
Copy link
Contributor

krsna-m commented Sep 26, 2023

/cc @dprotaso @psschwei

@knative-prow knative-prow bot requested a review from dprotaso September 26, 2023 13:50
@valen-mascarenhas14
Copy link
Contributor Author

Hey @kvmware

These changes are specific to ppc64le and do not introduce any major modifications. Previously, we were using a hardcoded IP address for VM when recreating the cluster for testing purposes. With these changes, we've implemented a script that dynamically selects a free VM and retrieves its IP address for cluster recreation.
All other aspects will continue to function as they did before. If there are any concerns or need for further clarification, please feel free to reach out.

@valen-mascarenhas14
Copy link
Contributor Author

@cardil @dprotaso @psschwei @kvmware any updates ?

cardil
cardil approved these changes Sep 27, 2023
View reviewed changes
Copy link
Contributor

@cardil cardil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Sep 27, 2023
@knative-prow
Copy link

knative-prow bot commented Sep 27, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cardil, valen-mascarenhas14

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 27, 2023
@knative-prow knative-prow bot merged commit 691ce1b into knative:main Sep 27, 2023
12 checks passed
@knative-prow
Copy link

knative-prow bot commented Sep 27, 2023

@valen-mascarenhas14: Updated the job-config configmap in namespace default at cluster default using the following files:

  • key kn-plugin-event-main.gen.yaml using file prow/jobs/generated/knative-extensions/kn-plugin-event-main.gen.yaml
  • key kn-plugin-event-release-1.10.gen.yaml using file prow/jobs/generated/knative-extensions/kn-plugin-event-release-1.10.gen.yaml
  • key kn-plugin-event-release-1.11.gen.yaml using file prow/jobs/generated/knative-extensions/kn-plugin-event-release-1.11.gen.yaml
  • key kn-plugin-event-release-1.9.gen.yaml using file prow/jobs/generated/knative-extensions/kn-plugin-event-release-1.9.gen.yaml
  • key client-main.gen.yaml using file prow/jobs/generated/knative/client-main.gen.yaml
  • key client-release-1.10.gen.yaml using file prow/jobs/generated/knative/client-release-1.10.gen.yaml
  • key client-release-1.11.gen.yaml using file prow/jobs/generated/knative/client-release-1.11.gen.yaml
  • key client-release-1.9.gen.yaml using file prow/jobs/generated/knative/client-release-1.9.gen.yaml
  • key eventing-main.gen.yaml using file prow/jobs/generated/knative/eventing-main.gen.yaml
  • key eventing-release-1.10.gen.yaml using file prow/jobs/generated/knative/eventing-release-1.10.gen.yaml
  • key eventing-release-1.11.gen.yaml using file prow/jobs/generated/knative/eventing-release-1.11.gen.yaml
  • key eventing-release-1.9.gen.yaml using file prow/jobs/generated/knative/eventing-release-1.9.gen.yaml
  • key operator-main.gen.yaml using file prow/jobs/generated/knative/operator-main.gen.yaml
  • key operator-release-1.10.gen.yaml using file prow/jobs/generated/knative/operator-release-1.10.gen.yaml
  • key operator-release-1.11.gen.yaml using file prow/jobs/generated/knative/operator-release-1.11.gen.yaml
  • key operator-release-1.9.gen.yaml using file prow/jobs/generated/knative/operator-release-1.9.gen.yaml
  • key serving-main.gen.yaml using file prow/jobs/generated/knative/serving-main.gen.yaml
  • key serving-release-1.10.gen.yaml using file prow/jobs/generated/knative/serving-release-1.10.gen.yaml
  • key serving-release-1.11.gen.yaml using file prow/jobs/generated/knative/serving-release-1.11.gen.yaml
  • key serving-release-1.9.gen.yaml using file prow/jobs/generated/knative/serving-release-1.9.gen.yaml

In response to this:

Signed-off-by: Valen Mascarenhas [email protected]

Which issue(s) this PR fixes:

Fixes

ppc64le specific changes added to prow config to support the new changes in the upstream ci repo

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krsna-m krsna-m krsna-m left review comments

@cardil cardil cardil approved these changes

@mgencur mgencur Awaiting requested review from mgencur

@psschwei psschwei Awaiting requested review from psschwei

@dprotaso dprotaso Awaiting requested review from dprotaso

Assignees

@cardil cardil

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@valen-mascarenhas14 @cardil @krsna-m