Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cron job timing modified for kafka broker 1.12 #264

Merged
merged 2 commits into from
Nov 20, 2023
Merged

Cron job timing modified for kafka broker 1.12 #264

merged 2 commits into from
Nov 20, 2023

Conversation

valen-mascarenhas14
Copy link
Contributor

Signed-off-by: Valen Mascarenhas [email protected]

Which issue(s) this PR fixes:

Fixes

PR to modify the Cron job timing for kafka broker 1.12

@knative-prow knative-prow bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Nov 20, 2023
Copy link

knative-prow bot commented Nov 20, 2023

Hi @valen-mascarenhas14. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow knative-prow bot requested review from cardil and krsna-m November 20, 2023 06:53
@knative-prow knative-prow bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 20, 2023
@cardil
Copy link
Contributor

cardil commented Nov 20, 2023

Please run hack/generate-configs.sh as well.

@valen-mascarenhas14
Copy link
Contributor Author

@cardil I've run the script and made the necessary changes

Copy link
Contributor

@cardil cardil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Nov 20, 2023
Copy link

knative-prow bot commented Nov 20, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cardil, valen-mascarenhas14

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 20, 2023
@knative-prow knative-prow bot merged commit 2977c8a into knative:main Nov 20, 2023
18 checks passed
Copy link

knative-prow bot commented Nov 20, 2023

@valen-mascarenhas14: Updated the job-config configmap in namespace default at cluster default using the following files:

  • key eventing-kafka-broker-release-1.12.gen.yaml using file prow/jobs/generated/knative-extensions/eventing-kafka-broker-release-1.12.gen.yaml

In response to this:

Signed-off-by: Valen Mascarenhas [email protected]

Which issue(s) this PR fixes:

Fixes

PR to modify the Cron job timing for kafka broker 1.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants