Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cronjob timings modified for knative ppc64le jobs #274

Merged
merged 1 commit into from
Nov 24, 2023
Merged

cronjob timings modified for knative ppc64le jobs #274

merged 1 commit into from
Nov 24, 2023

Conversation

valen-mascarenhas14
Copy link
Contributor

Signed-off-by: Valen Mascarenhas [email protected]

Which issue(s) this PR fixes:

Fixes

This PR modifies the cronjob timings for knative ppc64le jobs.

@knative-prow knative-prow bot requested review from cardil and mgencur November 23, 2023 09:00
@knative-prow Knative Prow
Copy link

knative-prow bot commented Nov 23, 2023

Hi @valen-mascarenhas14. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow knative-prow bot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 23, 2023
@valen-mascarenhas14
Copy link
Contributor Author

@cardil if everything looks good , could u please merge the PR ?

cardil
cardil approved these changes Nov 24, 2023
View reviewed changes
Copy link
Contributor

@cardil cardil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Nov 24, 2023
@knative-prow Knative Prow
Copy link

knative-prow bot commented Nov 24, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cardil, valen-mascarenhas14

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 24, 2023
@knative-prow knative-prow bot merged commit 2701cd2 into knative:main Nov 24, 2023
17 of 18 checks passed
@knative-prow Knative Prow
Copy link

knative-prow bot commented Nov 24, 2023

@valen-mascarenhas14: Updated the job-config configmap in namespace default at cluster default using the following files:

  • key eventing-kafka-broker-main.gen.yaml using file prow/jobs/generated/knative-extensions/eventing-kafka-broker-main.gen.yaml
  • key eventing-kafka-broker-release-1.10.gen.yaml using file prow/jobs/generated/knative-extensions/eventing-kafka-broker-release-1.10.gen.yaml
  • key eventing-kafka-broker-release-1.11.gen.yaml using file prow/jobs/generated/knative-extensions/eventing-kafka-broker-release-1.11.gen.yaml
  • key eventing-kafka-broker-release-1.12.gen.yaml using file prow/jobs/generated/knative-extensions/eventing-kafka-broker-release-1.12.gen.yaml
  • key kn-plugin-event-main.gen.yaml using file prow/jobs/generated/knative-extensions/kn-plugin-event-main.gen.yaml
  • key kn-plugin-event-release-1.10.gen.yaml using file prow/jobs/generated/knative-extensions/kn-plugin-event-release-1.10.gen.yaml
  • key kn-plugin-event-release-1.11.gen.yaml using file prow/jobs/generated/knative-extensions/kn-plugin-event-release-1.11.gen.yaml
  • key kn-plugin-event-release-1.12.gen.yaml using file prow/jobs/generated/knative-extensions/kn-plugin-event-release-1.12.gen.yaml
  • key client-main.gen.yaml using file prow/jobs/generated/knative/client-main.gen.yaml
  • key client-release-1.10.gen.yaml using file prow/jobs/generated/knative/client-release-1.10.gen.yaml
  • key client-release-1.11.gen.yaml using file prow/jobs/generated/knative/client-release-1.11.gen.yaml
  • key client-release-1.12.gen.yaml using file prow/jobs/generated/knative/client-release-1.12.gen.yaml
  • key eventing-main.gen.yaml using file prow/jobs/generated/knative/eventing-main.gen.yaml
  • key eventing-release-1.10.gen.yaml using file prow/jobs/generated/knative/eventing-release-1.10.gen.yaml
  • key eventing-release-1.11.gen.yaml using file prow/jobs/generated/knative/eventing-release-1.11.gen.yaml
  • key eventing-release-1.12.gen.yaml using file prow/jobs/generated/knative/eventing-release-1.12.gen.yaml
  • key operator-main.gen.yaml using file prow/jobs/generated/knative/operator-main.gen.yaml
  • key operator-release-1.10.gen.yaml using file prow/jobs/generated/knative/operator-release-1.10.gen.yaml
  • key operator-release-1.11.gen.yaml using file prow/jobs/generated/knative/operator-release-1.11.gen.yaml
  • key operator-release-1.12.gen.yaml using file prow/jobs/generated/knative/operator-release-1.12.gen.yaml
  • key serving-main.gen.yaml using file prow/jobs/generated/knative/serving-main.gen.yaml
  • key serving-release-1.10.gen.yaml using file prow/jobs/generated/knative/serving-release-1.10.gen.yaml
  • key serving-release-1.11.gen.yaml using file prow/jobs/generated/knative/serving-release-1.11.gen.yaml
  • key serving-release-1.12.gen.yaml using file prow/jobs/generated/knative/serving-release-1.12.gen.yaml

In response to this:

Signed-off-by: Valen Mascarenhas [email protected]

Which issue(s) this PR fixes:

Fixes

This PR modifies the cronjob timings for knative ppc64le jobs.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cardil cardil cardil approved these changes

@mgencur mgencur Awaiting requested review from mgencur

Assignees

@cardil cardil

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@valen-mascarenhas14 @cardil