Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

re-enable keda tests for ekb #276

Merged
merged 1 commit into from
Nov 28, 2023

Conversation

Cali0707
Copy link
Member

This PR re-enables the keda tests in eventing kafka broker now that they are passing thanks to knative-extensions/eventing-kafka-broker#3479

Signed-off-by: Calum Murray <[email protected]>
@Cali0707 Cali0707 requested a review from pierDipi November 23, 2023 18:52
Copy link

knative-prow bot commented Nov 23, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Cali0707

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot requested review from cardil and mgencur November 23, 2023 18:52
@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 23, 2023
@krsna-m
Copy link
Contributor

krsna-m commented Nov 28, 2023

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Nov 28, 2023
@knative-prow knative-prow bot merged commit 5f9a49f into knative:main Nov 28, 2023
18 checks passed
Copy link

knative-prow bot commented Nov 28, 2023

@Cali0707: Updated the job-config configmap in namespace default at cluster default using the following files:

  • key eventing-kafka-broker-main.gen.yaml using file prow/jobs/generated/knative-extensions/eventing-kafka-broker-main.gen.yaml

In response to this:

This PR re-enables the keda tests in eventing kafka broker now that they are passing thanks to knative-extensions/eventing-kafka-broker#3479

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants