Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Golang to latest patch release #281

Merged
merged 1 commit into from
Nov 29, 2023

Conversation

dsimansk
Copy link
Contributor

The newer patch version of Golang should fix the issue with license check.

Reported here as well: https://cloud-native.slack.com/archives/C04LKEZUXEE/p1700817496481049

1.21.3

➜  client git:(auto-updates/update-deps-main) eval "$(gvm 1.21.3)"
➜  client git:(auto-updates/update-deps-main) go-licenses check ./...
E1129 09:59:30.412368   20088 library.go:117] Package errors does not have module info. Non go modules projects are no longer supported. For feedback, refer to https://github.com/google/go-licenses/issues/128.
E1129 09:59:30.412515   20088 library.go:117] Package fmt does not have module info. Non go modules projects are no longer supported. For feedback, refer to https://github.com/google/go-licenses/issues/128.
E1129 09:59:30.414523   20088 library.go:117] Package bytes does not have module info. Non go modules projects are no longer supported. For feedback, refer to https://github.com/google/go-licenses/issues/128.
E1129 09:59:30.414531   20088 library.go:117] Package os does not have module info. Non go modules projects are no longer supported. For feedback, refer to https://github.com/google/go-licenses/issues/128.
E1129 09:59:30.414535   20088 library.go:117] Package os/exec does not have module info. Non go modules projects are no longer supported. For feedback, refer to https://github.com/google/go-licenses/issues/128.
E1129 09:59:30.414538   20088 library.go:117] Package path/filepath does not have module info. Non go modules projects are no longer supported. For feedback, refer to https://github.com/google/go-licenses/issues/128.
W1129 09:59:30.414544   20088 library.go:101] "runtime" contains non-Go code that can't be inspected for further dependencies:

1.21.4

➜  client git:(auto-updates/update-deps-main) eval "$(gvm 1.21.4)"
➜  client git:(auto-updates/update-deps-main) echo $GOROOT
/Users/dsimansk/.gvm/versions/go1.21.4.darwin.arm64
➜  client git:(auto-updates/update-deps-main) go-licenses check ./...
W1129 09:58:44.215024   19906 library.go:101] "golang.org/x/sys/unix" contains non-Go code that can't be inspected for further dependencies:
/Users/dsimansk/Git/knative/client/vendor/golang.org/x/sys/unix/asm_bsd_arm64.s
/Users/dsimansk/Git/knative/client/vendor/golang.org/x/sys/unix/zsyscall_darwin_arm64.s
W1129 09:58:45.275226   19906 library.go:101] "github.com/modern-go/reflect2" contains non-Go code that can't be inspected for further dependencies:
/Users/dsimansk/Git/knative/client/vendor/github.com/modern-go/reflect2/relfect2_arm64.s
/Users/dsimansk/Git/knative/client/vendor/github.com/modern-go/reflect2/relfect2_mips64x.s
/Users/dsimansk/Git/knative/client/vendor/github.com/modern-go/reflect2/relfect2_mipsx.s
/Users/dsimansk/Git/knative/client/vendor/github.com/modern-go/reflect2/relfect2_ppc64x.s
W1129 09:58:52.017968   19906 library.go:101] "github.com/cespare/xxhash/v2" contains non-Go code that can't be inspected for further dependencies:
/Users/dsimansk/Git/knative/client/vendor/github.com/cespare/xxhash/v2/xxhash_arm64.s
W1129 09:58:54.418513   19906 library.go:101] "go.starlark.net/starlark" contains non-Go code that can't be inspected for further dependencies:
/Users/dsimansk/Git/knative/client/vendor/go.starlark.net/starlark/empty.s

/cc @knative/productivity-reviewers
/cc @matejvasek @cardil

@knative-prow knative-prow bot requested a review from matejvasek November 29, 2023 09:09
Copy link

knative-prow bot commented Nov 29, 2023

@dsimansk: GitHub didn't allow me to request PR reviews from the following users: knative/productivity-reviewers.

Note that only knative members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

The newer patch version of Golang should fix the issue with license check.

Reported here as well: https://cloud-native.slack.com/archives/C04LKEZUXEE/p1700817496481049

1.21.3

➜  client git:(auto-updates/update-deps-main) eval "$(gvm 1.21.3)"
➜  client git:(auto-updates/update-deps-main) go-licenses check ./...
E1129 09:59:30.412368   20088 library.go:117] Package errors does not have module info. Non go modules projects are no longer supported. For feedback, refer to https://github.com/google/go-licenses/issues/128.
E1129 09:59:30.412515   20088 library.go:117] Package fmt does not have module info. Non go modules projects are no longer supported. For feedback, refer to https://github.com/google/go-licenses/issues/128.
E1129 09:59:30.414523   20088 library.go:117] Package bytes does not have module info. Non go modules projects are no longer supported. For feedback, refer to https://github.com/google/go-licenses/issues/128.
E1129 09:59:30.414531   20088 library.go:117] Package os does not have module info. Non go modules projects are no longer supported. For feedback, refer to https://github.com/google/go-licenses/issues/128.
E1129 09:59:30.414535   20088 library.go:117] Package os/exec does not have module info. Non go modules projects are no longer supported. For feedback, refer to https://github.com/google/go-licenses/issues/128.
E1129 09:59:30.414538   20088 library.go:117] Package path/filepath does not have module info. Non go modules projects are no longer supported. For feedback, refer to https://github.com/google/go-licenses/issues/128.
W1129 09:59:30.414544   20088 library.go:101] "runtime" contains non-Go code that can't be inspected for further dependencies:

1.21.4

➜  client git:(auto-updates/update-deps-main) eval "$(gvm 1.21.4)"
➜  client git:(auto-updates/update-deps-main) echo $GOROOT
/Users/dsimansk/.gvm/versions/go1.21.4.darwin.arm64
➜  client git:(auto-updates/update-deps-main) go-licenses check ./...
W1129 09:58:44.215024   19906 library.go:101] "golang.org/x/sys/unix" contains non-Go code that can't be inspected for further dependencies:
/Users/dsimansk/Git/knative/client/vendor/golang.org/x/sys/unix/asm_bsd_arm64.s
/Users/dsimansk/Git/knative/client/vendor/golang.org/x/sys/unix/zsyscall_darwin_arm64.s
W1129 09:58:45.275226   19906 library.go:101] "github.com/modern-go/reflect2" contains non-Go code that can't be inspected for further dependencies:
/Users/dsimansk/Git/knative/client/vendor/github.com/modern-go/reflect2/relfect2_arm64.s
/Users/dsimansk/Git/knative/client/vendor/github.com/modern-go/reflect2/relfect2_mips64x.s
/Users/dsimansk/Git/knative/client/vendor/github.com/modern-go/reflect2/relfect2_mipsx.s
/Users/dsimansk/Git/knative/client/vendor/github.com/modern-go/reflect2/relfect2_ppc64x.s
W1129 09:58:52.017968   19906 library.go:101] "github.com/cespare/xxhash/v2" contains non-Go code that can't be inspected for further dependencies:
/Users/dsimansk/Git/knative/client/vendor/github.com/cespare/xxhash/v2/xxhash_arm64.s
W1129 09:58:54.418513   19906 library.go:101] "go.starlark.net/starlark" contains non-Go code that can't be inspected for further dependencies:
/Users/dsimansk/Git/knative/client/vendor/go.starlark.net/starlark/empty.s

/cc @knative/productivity-reviewers
/cc @matejvasek @cardil

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow knative-prow bot requested a review from cardil November 29, 2023 09:09
@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 29, 2023
Copy link
Contributor

@cardil cardil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@upodroid can you double check?

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Nov 29, 2023
@cardil
Copy link
Contributor

cardil commented Nov 29, 2023

/hold

@knative-prow knative-prow bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 29, 2023
@cardil
Copy link
Contributor

cardil commented Nov 29, 2023

/assign @upodroid

Copy link
Member

@upodroid upodroid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@davidhadas this change should fix the broken go-licenses issue.

Copy link

knative-prow bot commented Nov 29, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dsimansk, upodroid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@upodroid
Copy link
Member

/hold cancel

@knative-prow knative-prow bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 29, 2023
@knative-prow knative-prow bot merged commit 81431e1 into knative:main Nov 29, 2023
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants