Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-1.10] Rebuild using Go 1.20.10 (to address CVEs) #14501

Merged
merged 1 commit into from
Oct 11, 2023
Merged

[release-1.10] Rebuild using Go 1.20.10 (to address CVEs) #14501

merged 1 commit into from
Oct 11, 2023

Conversation

ReToCode
Copy link
Member

@knative-prow knative-prow bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 11, 2023
@knative-prow knative-prow bot requested review from carlisia and jsanin-vmw October 11, 2023 10:01
@knative-prow knative-prow bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 11, 2023
@codecov
Copy link

codecov bot commented Oct 11, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (60754c3) 86.20% compared to head (a9b7a56) 86.21%.

Additional details and impacted files 
@@               Coverage Diff                @@
##           release-1.10   #14501      +/-   ##
================================================
+ Coverage         86.20%   86.21%   +0.01%     
================================================
  Files               199      199              
  Lines             14766    14766              
================================================
+ Hits              12729    12731       +2     
+ Misses             1735     1733       -2     
  Partials            302      302

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ReToCode
Copy link
Member Author

/retest
/unhold

@knative-prow knative-prow bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 11, 2023
@ReToCode ReToCode assigned nak3 and skonto and unassigned skonto Oct 11, 2023
@ReToCode ReToCode mentioned this pull request Oct 11, 2023
Closed
30 tasks
@ReToCode
Copy link
Member Author

/retest

@dprotaso
Copy link
Member

/override "test (v1.24.7, kourier-tls, e2e)"
/override "test (v1.26.0, kourier-tls, e2e)"
/override "test (v1.25.3, kourier-tls, e2e)"

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Oct 11, 2023
@knative-prow
Copy link

knative-prow bot commented Oct 11, 2023

@dprotaso: Overrode contexts on behalf of dprotaso: test (v1.24.7, kourier-tls, e2e), test (v1.25.3, kourier-tls, e2e), test (v1.26.0, kourier-tls, e2e)

In response to this:

/override "test (v1.24.7, kourier-tls, e2e)"
/override "test (v1.26.0, kourier-tls, e2e)"
/override "test (v1.25.3, kourier-tls, e2e)"

/lgtm
/approve

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow
Copy link

knative-prow bot commented Oct 11, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, ReToCode

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 11, 2023
@dprotaso
Copy link
Member

/override "test (v1.25.3, contour, e2e)"

@knative-prow
Copy link

knative-prow bot commented Oct 11, 2023

@dprotaso: Overrode contexts on behalf of dprotaso: test (v1.25.3, contour, e2e)

In response to this:

/override "test (v1.25.3, contour, e2e)"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow knative-prow bot merged commit 1c0fa5d into knative:release-1.10 Oct 11, 2023
50 of 54 checks passed
openshift-ci bot pushed a commit to openshift-knative/serving that referenced this pull request Oct 12, 2023
@ReToCode @knative-prow-robot
@dprotaso @KauzClay @nak3
[release-1.10] sync with upstream to include CVE patches (#473)
bfaa22c 
* Min TLS for tag to digest defaults to 1.2 again and is configurable (knative#13963)

quay.io only supports 1.2

Co-authored-by: dprotaso <[email protected]>

* drop safe to evict annotations (knative#14051)

this prevents nodes from draining

Co-authored-by: dprotaso <[email protected]>

* [release-1.10] RandomChoice 2 policy wasn't random when the number of targets is 2 (with equal weight) (knative#14052)

* RandomChoice 2 policy wasn't random when the number of targets is 2

* fix linting

---------

Co-authored-by: dprotaso <[email protected]>

* [release-1.10] fix securityContext for Knative Service Pod (user-container and queue-proxy) (knative#14377)

* add seccompProfile to queue container security context

* run as non root by default

* update tests to expect new default run as nonroot

* fix perms

---------

Co-authored-by: Clay Kauzlaric <[email protected]>
Co-authored-by: Dave Protasowski <[email protected]>

* Leave a comment which will trigger a new dot release (knative#14501)

* [release-1.10] bump x/net to v0.17 (knative#14517)

* [release-1.10] bump x/net to v0.17

* Re-generate test/config/tls/cert-secret.yaml (knative#14324)

* Run hack/upgrade

* Update secure-pod-defaults patch

* Use a static value for S-O branch

---------

Co-authored-by: Knative Prow Robot <[email protected]>
Co-authored-by: dprotaso <[email protected]>
Co-authored-by: Clay Kauzlaric <[email protected]>
Co-authored-by: Kenjiro Nakayama <[email protected]>
openshift-ci bot pushed a commit to openshift-knative/serving that referenced this pull request Oct 20, 2023
@ReToCode @knative-prow-robot
@dprotaso @KauzClay @nak3 @evankanderson
[release-1.10] sync with upstream (#488)
f0f4127 
* Min TLS for tag to digest defaults to 1.2 again and is configurable (knative#13963)

quay.io only supports 1.2

Co-authored-by: dprotaso <[email protected]>

* drop safe to evict annotations (knative#14051)

this prevents nodes from draining

Co-authored-by: dprotaso <[email protected]>

* [release-1.10] RandomChoice 2 policy wasn't random when the number of targets is 2 (with equal weight) (knative#14052)

* RandomChoice 2 policy wasn't random when the number of targets is 2

* fix linting

---------

Co-authored-by: dprotaso <[email protected]>

* [release-1.10] fix securityContext for Knative Service Pod (user-container and queue-proxy) (knative#14377)

* add seccompProfile to queue container security context

* run as non root by default

* update tests to expect new default run as nonroot

* fix perms

---------

Co-authored-by: Clay Kauzlaric <[email protected]>
Co-authored-by: Dave Protasowski <[email protected]>

* Leave a comment which will trigger a new dot release (knative#14501)

* [release-1.10] bump x/net to v0.17 (knative#14517)

* [release-1.10] bump x/net to v0.17

* Re-generate test/config/tls/cert-secret.yaml (knative#14324)

* Run hack/upgrade

* Bound buffer for reading stats (knative#14541)

Co-authored-by: Evan Anderson <[email protected]>

---------

Co-authored-by: Knative Prow Robot <[email protected]>
Co-authored-by: dprotaso <[email protected]>
Co-authored-by: Clay Kauzlaric <[email protected]>
Co-authored-by: Kenjiro Nakayama <[email protected]>
Co-authored-by: Evan Anderson <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carlisia carlisia Awaiting requested review from carlisia

@jsanin-vmw jsanin-vmw Awaiting requested review from jsanin-vmw

Assignees

@dprotaso dprotaso

@nak3 nak3

@skonto skonto

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ReToCode @dprotaso @nak3 @skonto