Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop CI reverse compatibility for auto-tls rename #14595

Merged
merged 1 commit into from
Nov 7, 2023

Conversation

ReToCode
Copy link
Member

@ReToCode ReToCode commented Nov 6, 2023

@knative-prow knative-prow bot added area/test-and-release It flags unit/e2e/conformance/perf test issues for product features size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 6, 2023
@ReToCode
Copy link
Member Author

ReToCode commented Nov 6, 2023

/hold

Copy link

knative-prow bot commented Nov 6, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ReToCode

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Nov 6, 2023
Copy link

codecov bot commented Nov 6, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (789c322) 85.93% compared to head (ddb5017) 86.05%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #14595      +/-   ##
==========================================
+ Coverage   85.93%   86.05%   +0.12%     
==========================================
  Files         197      197              
  Lines       14916    14916              
==========================================
+ Hits        12818    12836      +18     
+ Misses       1784     1772      -12     
+ Partials      314      308       -6     

see 6 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ReToCode
Copy link
Member Author

ReToCode commented Nov 7, 2023

/retest

@ReToCode
Copy link
Member Author

ReToCode commented Nov 7, 2023

/assign @nak3
/unhold

@knative-prow knative-prow bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 7, 2023
@nak3
Copy link
Contributor

nak3 commented Nov 7, 2023

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Nov 7, 2023
@knative-prow knative-prow bot merged commit f3e1a2d into knative:main Nov 7, 2023
68 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test-and-release It flags unit/e2e/conformance/perf test issues for product features lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use the aligned flags and certificate secrets in all components
3 participants