[kraken] add different network support for currency deposit addresses #4831
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
duplessisc
pushed a commit
to duplessisc/XChange
that referenced
this pull request
May 29, 2024
…sit-support [kraken] add different network support for currency deposit addresses
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation doesn't allow for getting addresses with tags (eg XRP) and also if you have currencies with multiple methods (eg USDT, USDC) it is not supported.
This PR introduces a new change to the AccountService interface to allow for more structured complex deposit address requests with a default to the current methods.
It implements this new method on Kraken also inferring the appropriate method where possible with some clear exceptions if it isn't able to do so, so the user can refine their request if desired.