Binance dapi fix #4876
Merged
Binance dapi fix #4876
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…fix_no-PR' into PR/binance-dapi-fix
bigscoop
reviewed
May 10, 2024
...-binance/src/test/java/info/bitrich/xchangestream/binance/BinanceStreamExchangeTypeTest.java
Outdated
Show resolved
Hide resolved
xchange-binance/src/test/java/org/knowm/xchange/binance/BinanceExchangeTypeTest.java
Outdated
Show resolved
Hide resolved
xchange-binance/src/main/java/org/knowm/xchange/binance/service/BinanceAccountService.java
Outdated
Show resolved
Hide resolved
xchange-binance/src/main/java/org/knowm/xchange/binance/service/BinanceBaseService.java
Show resolved
Hide resolved
timmolter
reviewed
May 10, 2024
xchange-binance/src/test/java/org/knowm/xchange/binance/BinanceExchangeTypeTest.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At first I was just going to fix this #4807 bug.
douggie, author of #4785, disappeared for a long time.
But when I saw what a mess it turns out after adding
SPOT, FUTURES, INVERSE_FUTURES, PORTOLIO_MARGIN and three more have SANDBOX options.
Then I decided to rework this moment into enum.
4 enums and one SANDBOX option for all.
breaks compatibility a little for futures users, but not spot.