Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bitfinex] Minor fixes #4981

Merged
merged 2 commits into from
Dec 14, 2024
Merged

[bitfinex] Minor fixes #4981

merged 2 commits into from
Dec 14, 2024

Conversation

bigscoop
Copy link
Contributor

Minor fixes for bitfinex:

  • Replaced boilerplate code with lombok annotations
  • fixed NPE when adapting percentageChange field
  • Switched argument from CurrencyPair to recommended Instrument at getting of order book
  • Replaced some direct member access with getters

@timmolter timmolter merged commit 494027c into knowm:develop Dec 14, 2024
1 check passed
@bigscoop bigscoop deleted the bitfinex-fixes branch December 14, 2024 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants