Split ExecutionEngine::execute into smaller functions
#549
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matzemathics
force-pushed
the
partition-execution-engine-loop
branch
from
595e784
to
e0a97d3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
note: based on #548
Rule execution is now performed in
ExecutionEngine::step, which returns aVecof the changed predicates. De fragmentation of tables is performed separately inExecutionEngine::defrag.Also
ExectionEngine::initializetakes ownership of itsProgramparameter instead of taking a reference and then cloning it, which is just bad practice.Finally the odd
ChaseProgramparameter, which was handed down to the tracing functions is removed, by being a bit more conscious about where and what to clone. Note that this will likely change later, as I'm cleaning up more of the tracing code.