Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support dynamic base URL #723

Merged
merged 1 commit into from
Sep 7, 2023
Merged

Support dynamic base URL #723

merged 1 commit into from
Sep 7, 2023

Conversation

shalvah
Copy link
Contributor

@shalvah shalvah commented Sep 7, 2023

@shalvah shalvah merged commit b32959d into master Sep 7, 2023
6 checks passed
@shalvah shalvah deleted the dynamic_base_url branch September 7, 2023 19:57
@deefour
Copy link

deefour commented Oct 2, 2023

@shalvah I haven't had the time to trace $baseUrl back further yet, but I wanted to point out with the 'base_url' left as null for both scribe proper and 'try it out,' pulling in this change breaks 'try it out.'

We end up with undefined/our/endopint/path/here seemingly because scribe isn't setting up $baseUrl properly for the views.

image

@deefour
Copy link

deefour commented Oct 2, 2023

@shalvah I think I sorted it, but wish to communicate in case it helps for later changelogs.

baseUrl in the scribe default index.blade.php was changed/replaced/... with tryItOutBaseUrl at some point. Our upgrade from 4.18 to 4.25 became broken because of this (we have a custom theme!), and it seems it wasn't documented in the Changelog (did I miss it)?

@shalvah
Copy link
Contributor Author

shalvah commented Oct 10, 2023

Ah, yeah, that's from the localisation feature released in 4.25.0. #647

Sorry about that. Tbh, it's not so easy to maintain backwards compatibility for custom themes, but I'll keep that in mind going forward. Maybe I'll just add both old and new variables instead of renaming.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants