Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TEST] Update Test Case for Route Processing - PR #718 #732

Closed
wants to merge 2 commits into from

Conversation

zfhassaan
Copy link

Description

This Pull Request addresses and updates the test case for route processing in the context of PR #718. The changes ensure that the test case accurately reflects the expected behavior when checking if a route can be processed based on the controller and method, as specified in the code changes and discussions.

Changes Made

  • Refactored the can_process_routes_on_dingo test case to improve clarity and reliability.
  • Added a new private method, canProcessRoute, to check if a route can be processed.
  • Added a new private method, getRouteControllerAndMethod, to extract controller and method information from a route.
  • Enhanced the routeCanBeProcessed method to verify if a route can be processed based on the extracted controller and method.

Context

This PR is associated with Issue #718 and ensures that the test case aligns with the code changes made in the PR. It improves the maintainability of the test case and its reliability for future updates and changes.

How to Test

  1. Clone this PR branch locally.
  2. Run the test suite to verify that the updated test case functions as expected.

Related PRs and Issues

Checklist

  • All tests pass successfully.
  • Code follows the project's coding standards and guidelines.
  • It also handles the closures and Controller classes, only 1 is not fixed.

Please review and merge this PR to ensure that the test case accurately represents the intended behavior and contributes to the overall reliability of the project.

@shalvah
Copy link
Contributor

shalvah commented Sep 18, 2023

Tests are still failing; do you need some help?

@zfhassaan zfhassaan closed this Sep 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants