Ability to add cursor pagination #735
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Extend model pagination with cursor pagination. ``` @apiResourceModel App\Models\User paginate=10,cursor ```
|
You need to add tests 😬 |
|
Hey, are you still interested in adding this? Do you need help adding tests? |
|
@shalvah that would be good |
|
Hey 👋 Was about to open a PR for this but saw this one already existed. Is this currently being worked on? Else I don't mind giving a hand with the missing tests. |
|
Still open to merging this once a test is added. (Sorry, I'm fairly busy, so can't do much myself.) |
|
@shalvah no worries at all, thank you for all the work you do maintaining this project! I have opened a PR which adds tests for it and updated the attribute. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extend model pagination with cursor pagination.
Example: