Confusing use of '!'.

kochizufan · Mar 19, 2012 · 5557693 · 5557693
1 parent 20e35b1
commit 5557693
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 4 deletions.
diff --git a/lib/OpenLayers/Control/OverviewMap.js b/lib/OpenLayers/Control/OverviewMap.js
@@ -202,7 +202,7 @@ OpenLayers.Control.OverviewMap = OpenLayers.Class(OpenLayers.Control, {
      */    
     draw: function() {
         OpenLayers.Control.prototype.draw.apply(this, arguments);
-        if(!(this.layers.length > 0)) {
+        if (this.layers.length === 0) {
             if (this.map.baseLayer) {
                 var layer = this.map.baseLayer.clone();
                 this.layers = [layer];

diff --git a/lib/OpenLayers/Layer/EventPane.js b/lib/OpenLayers/Layer/EventPane.js
@@ -255,8 +255,7 @@ OpenLayers.Layer.EventPane = OpenLayers.Class(OpenLayers.Layer, {
                 var moOldZoom = this.getMapObjectZoom();
                 var oldZoom= this.getOLZoomFromMapObjectZoom(moOldZoom);
 
-                if ( !(newCenter.equals(oldCenter)) || 
-                     !(newZoom == oldZoom) ) {
+                if (!(newCenter.equals(oldCenter)) || newZoom != oldZoom) {
 
                     if (!zoomChanged && oldCenter && this.dragPanMapObject && 
                         this.smoothDragPan) {

diff --git a/lib/OpenLayers/Request.js b/lib/OpenLayers/Request.js
@@ -79,7 +79,7 @@ OpenLayers.Request = {
      *     will be the same as the provided url.
      */
     makeSameOrigin: function(url, proxy) {
-        var sameOrigin = !(url.indexOf("http") == 0);
+        var sameOrigin = url.indexOf("http") !== 0;
         var urlParts = !sameOrigin && url.match(this.URL_SPLIT_REGEX);
         if (urlParts) {
             var location = window.location;