Removing redundant redraw. This patch is an excellent example of how …

…things should be done, well done jorix. p=jorix, r=me (closes #2837) git-svn-id: http://svn.openlayers.org/trunk/openlayers@10734 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
kochizufan · Sep 14, 2010 · c70a97f · c70a97f
1 parent 5417057
commit c70a97f
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 2 deletions.
diff --git a/lib/OpenLayers/Control/Panel.js b/lib/OpenLayers/Control/Panel.js
@@ -207,7 +207,6 @@ OpenLayers.Control.Panel = OpenLayers.Class(OpenLayers.Control, {
             } else {
                 control.activate();
             }
-            this.redraw();
             return;
         }
         var c;

diff --git a/tests/Control/Panel.html b/tests/Control/Panel.html
@@ -67,7 +67,7 @@
 
         panel.redrawsCount = 0;              
         panel.activateControl(toggleControl);
-        t.ok((panel.redrawsCount > 0),"Redraw called on activated toggle " +
+        t.eq(panel.redrawsCount, 1, "Redraw called on activated toggle " +
             panel.redrawsCount + " times.");
         t.ok(toolControl.active && !anotherToolControl.active && toggleControl.active,
               "activated the toggle control, which has no influence on the tool & togggle controls.");
-Original file line number
+Diff line change
@@ Expand Up @@
                 } else {
                     control.activate();
                 }
-                this.redraw();
                 return;
             }
             var c;
@@ Expand Down @@