Merge pull request openlayers#214 from fredj/popup-css

Move the popup close box sizing to CSS. r=ahocevar
kochizufan · Feb 12, 2012 · d106aab · d106aab
2 parents 3fae6c0 + 134f244
commit d106aab
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 4 deletions.
diff --git a/lib/OpenLayers/Popup.js b/lib/OpenLayers/Popup.js
@@ -872,13 +872,11 @@ OpenLayers.Popup = OpenLayers.Class({
      */
     addCloseBox: function(callback) {
 
-        this.closeDiv = OpenLayers.Util.createDiv(
-            this.id + "_close", null, {w: 17, h: 17}
-        );
+        this.closeDiv = OpenLayers.Util.createDiv(this.id + "_close");
         this.closeDiv.className = "olPopupCloseBox"; 
 
         // use the content div's css padding to determine if we should
-        //  padd the close div
+        //  pad the close div
         var contentDivPadding = this.getContentDivPadding();
 
         this.closeDiv.style.right = contentDivPadding.right + "px";

diff --git a/notes/2.12.md b/notes/2.12.md
@@ -145,3 +145,6 @@ In addition, OpenLayers no longer modifies any native prototypes or objects by d
  * Function.prototype.bindAsEventListener
  * Event.stop
 
+## Popup close box size
+
+The size of the close box is now configurable in CSS instead of the fixed 17x17px (`.olPopupCloseBox`)
diff --git a/theme/default/style.css b/theme/default/style.css
@@ -259,6 +259,8 @@ div.olControlSaveFeaturesItemInactive {
 
 .olPopupCloseBox {
   background: url("img/close.gif") no-repeat;
+  width: 17px;
+  height: 17px;
   cursor: pointer;
 }