Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix comparison to return -1, 0, 1 and Improve xml element content comparison #14

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fix comparison to return -1, 0, 1 and Improve xml element content comparison #14

wants to merge 3 commits into from

Commits on Jun 2, 2021

  1. Fix comparison to respect -1, 0 or 1 return value, we can't assume re… 

    …turning 1 if col1 is lower than col2

Also improved comparison so when xml element have the same name and the same attributes, we shall then compare based on the xml content
for example:
<tests>
<test>2</test>
<test>1</test>
</tests>

should sort to:
<tests>
<test>1</test>
<test>2</test>
</tests>
    @bsrouji
    bsrouji committed Jun 2, 2021
    Configuration menu
    Copy the full SHA
    362d42a View commit details
    Browse the repository at this point in the history

Commits on Jun 3, 2021

  1. Proper fix with unit test for all use cases

    @bsrouji
    bsrouji committed Jun 3, 2021
    Configuration menu
    Copy the full SHA
    f898cba View commit details
    Browse the repository at this point in the history

  2. restructure folders

    @bsrouji
    bsrouji committed Jun 3, 2021
    Configuration menu
    Copy the full SHA
    738b2e9 View commit details
    Browse the repository at this point in the history