Allow empty default values - solves #19 #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow empty default values:
* Change regexp part for parsing default values to allow zero-or-more (so far
was one-or-more); keep the prefer-less flag
* Make the regexp part for default value syntax a capturing group: (\:\-)
* Add an additional "separator" parameter to the capture function to see
whether the default value separator was used
* Add a corresponding constant DefaultValueSyntax with the separator value (":-")
* Change the logic for testing whether a default value was provided to check
whether the separator is non-empty.
* TEST: adjust TestCapture accordingly to also handle separator values
* TEST: test the newly supported empty-default-value syntax in TestFullParseDefaults function
|
Looks pretty good - please allow me a couple of days before merging. A new release should be ready until the end of the week! |
|
LGTM! |
yawn
added a commit
that referenced
this pull request
Jan 26, 2016
Allow empty default values - solves #19
|
Hi, Thanks for merging my pull request. Could you please also make a release to fully close this off? Many thanks in advance! Cheers, |
|
Hi, I didn't mean to rush you! It's not urgent for me to have the release now - I was just probing if it's not stalled. All fine if you need some more time - can wait without doing an intermediate release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow empty default values:
was one-or-more); keep the prefer-less flag
(\:\-)whether the default value separator was used
DefaultValueSyntaxwith the separator value (":-")whether the separator is non-empty.
TestCaptureaccordingly to also handle separator valuesTestFullParseDefaultsfunction