Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(messaging): make waitUntil warning clearer #29

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

pkarl
Copy link

@pkarl pkarl commented Aug 12, 2024

  • add function name to missing waitUntil warning to improve findability when warning surfaces in cloudflare/miniflare

Suggesting this change b/c neither I nor the cloudflare devs knew what was causing this warning/error.

Currently, this warning is surfaced like this when running wrangler dev:
image

...and like this in cloudflare logpush (irrelevant information omitted):

{
    $cloudflare:
        {
            event: { Cron: "0 * * * *", ScheduledTimeMs: ... },
            requestId: "...",
            scriptName: "...",
            outcome: "ok",
            eventType: "scheduled",
        },
    message: "Missing `waitUntil` option.",
    $baselime:
        {
            namespace: "0 * * * *",
            requestId: "...",
            account: "...",
            service: "...",
            dataset: "cloudflare-workers",
            baselimeId: "...",
            type: "cf-worker-req",
            messagePattern: "Missing `waitUntil` option.",
        },
}

… when warning surfaces in cloudflare/miniflare
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant