-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change API from 'Google API Client' to 'Google Cloud Python Client' #723
base: main
Are you sure you want to change the base?
Conversation
Not sure if this is part of what you added but at the end of the scenario i got this error
|
I took a look and this comes from here: Line 74 in 462c9ac
There's no |
b8521ff
to
7d84e0c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
if response.instances: | ||
for instance in response.instances: | ||
if instance.name in node: | ||
return instance |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the power shut down scenario to properly call the stop instances we need to have this funtion return both the instance name and the zone. See the previous return line
Getting error:
2024-11-01 13:53:11,827 [INFO] Error on pool multiprocessing: stop_instances() missing 1 required positional argument: 'instance_id'
2024-11-01 13:53:11,828 [ERROR] ShutDownScenarioPlugin scenario scenarios/openshift/cluster_shut_down_scenario.yml failed with exception: wait_until_stopped() missing 1 required positional argument: 'timeout'
2024-11-01 13:53:12,441 [INFO] wating 60 before running the next scenario
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pablomh can you review the ^ comment when you get time please. Thanks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still hitting this issue:
2024-12-09 11:47:43,348 [INFO] Starting cluster_shut_down scenario injection
2024-12-09 11:47:43,420 [INFO] nodes type <class 'str'>
2024-12-09 11:47:43,420 [INFO] pool type<class 'list'>
2024-12-09 11:47:43,421 [INFO] Error on pool multiprocessing: stop_instances() missing 1 required positional argument: 'instance_id'
2024-12-09 11:47:43,422 [ERROR] ShutDownScenarioPlugin scenario scenarios/openshift/cluster_shut_down_scenario.yml failed with exception: wait_until_stopped() missing 1 required positional argument: 'timeout'
Signed-off-by: Pablo Méndez Hernández <[email protected]>
According to the 'Google API Client' GH page: ``` This library is considered complete and is in maintenance mode. This means that we will address critical bugs and security issues but will not add any new features. This library is officially supported by Google. However, the maintainers of this repository recommend using Cloud Client Libraries for Python, where possible, for new code development. ``` So change the code accordingly to adapt it to 'Google Cloud Python Client'. Signed-off-by: Pablo Méndez Hernández <[email protected]>
I'll be able to keep working on it tomorrow, so keep tuned and let me know if I can help you with your issue. |
According to the 'Google API Client' GH page:
So change the code accordingly to adapt it to 'Google Cloud Python Client'.