Skip to content

Commit

Permalink
fully ignore platform reqs in phar build
Browse files Browse the repository at this point in the history
previously only on the re-install (with dev dependencies) the platform
requirements were ignored (composer install).

as it looks like an oversight and it makes no sense to only do so in the
second install command, also do so on the first install when the develop-
ment dependencies are removed for the build.

ignoring platform dependencies during the build makes sense to use a less
(or little) configured php runtime as for building (only) the platform
dependencies are not (or even should not be) required. at least this should
be more portable for the build (e.g. ext-json is not required for the
build).
  • Loading branch information
ktomk committed Mar 16, 2020
1 parent a541807 commit 56db23c
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 1 deletion.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.

## [unreleased]
### Changed
- Phar build: Do not require platform dependencies for composer install
- Travis build: Handle GPG key import before install completely
### Fixed
- Tainted phar build on Travis since 0.0.25 (adding "+" to versions in
Expand Down
2 changes: 1 addition & 1 deletion lib/build/build.php
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@
->remove('src/PharBuild/*')
// Composer autoloader has a flaw and requires a full install w/ --no-dev
// for the non-dev autoloader used in the phar file
->phpExec('composer -n -q install --no-dev')
->phpExec('composer -n -q install --ignore-platform-reqs --no-dev')
->add('vendor/{,composer/}*.php', $builder->snapShot())
->phpExec('composer -n -q install --ignore-platform-reqs')
// Dependencies
Expand Down

0 comments on commit 56db23c

Please sign in to comment.