-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: allow ipv4-mapped ipv6 addresses #4943
base: master
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Welcome @buroa! |
Hi @buroa. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Hey @stevehipwell, hope this is an easy one :) |
Signed-off-by: Steven Kreitzer <[email protected]>
@buroa this isn't really my area of expertise, but with my limited knowledge this looks OK to test ready for a review from one of the maintainers. /ok-to-test |
Hi @mloiseleur does this look okay? |
Description
Updates
suitableType
to allow all valid IPv6 addresses, including IPv4-mapped IPv6 addresses.https://pkg.go.dev/net/netip#Addr.Is6
Fixes #4942
Checklist