Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Cosign verify command with identity #38440

Closed
wants to merge 2 commits into from

Conversation

haydentherapper
Copy link

Verification of the identity of the signer is a critical part of Sigstore verification. Otherwise, you are only verifying that there is some signature that is valid, instead of checking that the signature was generated by someone you trust.

For more information, sigstore/cosign#2056 contains some discussion around why we want to require these flags, and sigstore/cosign#1947 for why we require both of these flags.

An open question for you is if this specified identity (which came from the certificate) will change between releases. If so, how would you like users to know which identity signed a release?

Verification of the identity of the signer is a critical part of Sigstore verification. Otherwise, you are only verifying that there is some signature that is valid, instead of checking that the signature was generated by someone you trust.

For more information, sigstore/cosign#2056 contains some discussion around why we want to require these flags, and sigstore/cosign#1947 for why we require both of these flags.

An open question for you is if this specified identity (which came from the certificate) will change between releases. If so, how would you like users to know which identity signed a release?
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Dec 13, 2022

CLA Signed

The committers listed above are authorized under a signed CLA.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign nate-double-u for approval by writing /assign @nate-double-u in a comment. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the language/en Issues or PRs related to English language label Dec 13, 2022
@k8s-ci-robot k8s-ci-robot requested a review from sftim December 13, 2022 03:37
@k8s-ci-robot k8s-ci-robot added sig/docs Categorizes an issue or PR as relevant to SIG Docs. cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Dec 13, 2022
@k8s-ci-robot
Copy link
Contributor

Welcome @haydentherapper!

It looks like this is your first PR to kubernetes/website 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/website has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Dec 13, 2022
@netlify
Copy link

netlify bot commented Dec 13, 2022

Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 40d6197
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/6397f381e0dd6400088caaf8
😎 Deploy Preview https://deploy-preview-38440--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@haydentherapper
Copy link
Author

Something that was unexpected is that the binary was signed by a different identity than the image - [email protected] vs [email protected]. Was this intentional?

@utkarsh-singh1
Copy link
Contributor

utkarsh-singh1 commented Dec 13, 2022

Hi @haydentherapper, please sign EasyCLA as it will allow reviewers to review your PR.

Check these links for EasyCLA -

  1. Find about EasyCLA here - https://docs.linuxfoundation.org/lfx/easycla

  2. Steps to sign EasyCLA are here - https://docs.linuxfoundation.org/v2/easycla/contributors/individual-contributor

  3. Follow this link for EasyCLA - https://api.easycla.lfx.linuxfoundation.org/v2/repository-provider/github/sign/18706487/51478266/38056/#/?version=2

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Dec 13, 2022
@haydentherapper haydentherapper marked this pull request as draft December 14, 2022 18:20
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 14, 2022
@haydentherapper
Copy link
Author

Moving PR to draft after speaking with @puerco about the expected identities.

@natalisucks
Copy link
Contributor

@haydentherapper Howdy there – just wanting to check in on the status of this draft. Happy to keep it open if you're still working, or close for now until an agreed upon way forward with the expected identities. Thanks!

@haydentherapper
Copy link
Author

I'll close it for now, unless there's an identity that's been locked in. We'll want to update the documentation for Cosign 2.0 also.

@haydentherapper haydentherapper deleted the patch-1 branch March 8, 2023 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants