Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XPish: add new icons for shade and desk #19

Merged
merged 1 commit into from
Aug 25, 2024
Merged

Conversation

01micko
Copy link
Contributor

@01micko 01micko commented Aug 25, 2024

Tested and works fine.

bar1svg

@Consolatis
Copy link
Member

Consolatis commented Aug 25, 2024

I don't really understand why the desk_toggled variants show a pin icon while clicking on the button makes the window only be on a single workspace (and not pinned e.g. on all workspaces). The Numix theme does the same so maybe I just don't get something.

Other than that confusion (that might totally only be on my side so feel free to ignore) this LGTM. Thanks!

@01micko 01micko merged commit 8f52471 into labwc:main Aug 25, 2024
1 check passed
@01micko 01micko deleted the new_icons branch August 25, 2024 05:56
@01micko
Copy link
Contributor Author

01micko commented Aug 25, 2024

Ha, added a comment but must have only 'previewed'. Anyway, works as expected here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants