-
-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow PHP 8.2, drop PHP 7 support #55
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like CI on 8.2 is unlikely to pass. You can try ignoring platform reqs on 8.2 like this: https://github.com/laminas/laminas-filter/blob/2.24.x/.laminas-ci.json but as the required extensions are missing, it's likely a case of waiting for them to be available in apt.
fd79fc5
to
b2daff3
Compare
This should be re-tried: the newer versions of CI include a bunch of 8.2 tooling now. |
Hmm, MongoDB missing is a bit of a pain, at this stage: will probably need to wait until after PHP 8.2 is released in Ondrej's PPAs. |
46a344d
to
83fff65
Compare
@Ocramius tests were failing because |
Signed-off-by: Ion Bazan <[email protected]>
Signed-off-by: Ion Bazan <[email protected]>
You can fix with run :
Psalm need fixing as well https://github.com/laminas/laminas-diagnostics/actions/runs/3728718218/jobs/6323968842#step:4:506 |
Signed-off-by: Ion Bazan <[email protected]>
Thanks @samsonasik - forgot to run that before pushing. Regarding Psalm errors, I'll try to fix that in a separate PR to keep the changes scoped. |
The remaining psalm issues are something I fixed in #62, but no time to pursue that further right now. I suggest re-generating the baseline: please make sure you do so from a compatible environment ( |
Signed-off-by: Ion Bazan <[email protected]>
Thanks for the tips, @Ocramius - turned out I had to pass |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @IonBazan
Signed-off-by: Ion Bazan [email protected]
Description
Allowing PHP 8.2 in
composer.json
and build matrix.Tests failing because some
php8.2-*
extensions are not available in https://launchpad.net/~ondrej/+archive/ubuntu/php/ PPA yet.