Channels implementation with new listeners #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
natsukagami
force-pushed
the
explicit-channels-prelim
branch
from
ede4896 to
d8f457c
Compare
... so that it no longer creates "spooky actions at a distance"
natsukagami
force-pushed
the
explicit-channels-prelim
branch
from
d8f457c to
8f41bc3
Compare
diesalbla
reviewed
Dec 9, 2023
m8nmueller
reviewed
Dec 10, 2023
| } | ||
| end UnboundedChannel | ||
|
|
||
| object Channel: |
There was a problem hiding this comment.
I think it would be possible to extract all listener completion outside of the synchronized parts to increase concurrency. But it is a tedious work.
There was a problem hiding this comment.
I think it is possible (in fact it should be possible to implement completely lock-free channels) but not right now
| subscribersCopy = subscribers.toList | ||
| for (s <- subscribersCopy) s.send(Failure(ChannelClosedException())) | ||
| shouldTerminate = true | ||
| case Right(Message.Refresh) => () |
There was a problem hiding this comment.
Why does this exist? And if it is only quit left, then I guess the info channel is not needed anymore. You can implement the quit using a (classical) Promise instead.
There was a problem hiding this comment.
Refresh is needed as like a continue for the while loop. Happens when we made a change to the subscriber/publisher list.
m8nmueller
force-pushed
the
explicit-channels-prelim
branch
from
b20f227 to
3fffabc
Compare
ChannelMultiplexer is very dependent on subscribing order, and should be either set up correctly or used by subscribers that don't really care about past events.
... to make it consistent with ChannelMultiplexer. Overall `start` sounds more like a background running thing w.r.t threads.
m8nmueller
approved these changes
Dec 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #21 and #22.
Channel stuff
lockBoth..sendImmediatelynon-suspending.start()method instead of spawning a background working.Stuff based on channels
Seq[Future[T]]=>ReadableChannel[Future[T]], with values arriving as they are completed.Seq[Future[T]]hasawaitAll(OrCancel) andaltAll(WithCancel)Other misc goodies
.awaitsyntax to sources.Source.valuesto quickly create a new source based on a list of values.