-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
langchain-google: remove possible trailing newline from content text in response candidates #598
langchain-google: remove possible trailing newline from content text in response candidates #598
Conversation
…ded trailing newline removal, added unit tests
PALM is going to be deprecated, do we really need this one? |
actually, if your original issue was with gemini-1.5 model, I'm not sure this PR will fix it. |
… response candidates, removed unecessary code from llm module
@lkuligin Good catch. I've reverted the earlier code and instead added trailing newline removal to the content text of response candidates. Before change:
After change:
|
@lkuligin are you able to approve this PR or is there someone else to tag? |
waiting for this fix too, thanks for the PR 👌🏼 |
…ngchain-google into strip-erroneous-characters
PR Description
Renamed
_strip_erroneous_spaces
to_strip_erroneous_characters
and added trailing newline removal, added unit tests for function.Relevant issues
24648
Type
🐛 Bug Fix
🧹 Refactoring
✅ Test
Changes(optional)
Testing(optional)
make test
77 passed, 6 warnings in 0.82s
Note(optional)