-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
community: Migrate Vertex AI Search Retriever from v1beta to v1 #630
base: main
Are you sure you want to change the base?
Conversation
…rsions of the Discovery Engine API.
Hey @lkuligin , I've added all the changes to support both the stable and beta versions of The changes turned out to be larger than expected. Thanks! |
The integration tests are failing, but I’m unable to see the CI log details. Could you help me check? Thanks so much! |
Please let me know if everything looks good or if there’s anything else needed. |
… imports and enhance initialization logic.
@lkuligin Thank you for the feedback! All the changes pushed. |
@lgesuellip thanks for the changes! some linting issues remain, take a look, please (probably it's enough just to ignore the warnings for now). |
@lkuligin I just updated it! Thanks, |
PR Description
Hey team, this PR migrates the Vertex AI Search Retriever from v1beta to the stable v1 API.
Type
🧹 Refactoring
✅ Test
Changes
Key changes:
discoveryengine_v1beta
todiscoveryengine_v1
VertexAISearchRetriever
: embedding_spec, ranking_expression, relevance_threshold, personalization_spec, and natural_language_query_understanding_specTesting
vertex_ai_search
.Thank you Team,