Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

community: Migrate Vertex AI Search Retriever from v1beta to v1 #630

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

lgesuellip
Copy link
Contributor

PR Description

Hey team, this PR migrates the Vertex AI Search Retriever from v1beta to the stable v1 API.

Type

🧹 Refactoring
✅ Test

Changes

Key changes:

  • Updated imports from discoveryengine_v1beta to discoveryengine_v1
  • Removed unsupported v1beta features from VertexAISearchRetriever: embedding_spec, ranking_expression, relevance_threshold, personalization_spec, and natural_language_query_understanding_spec
  • Removed custom embedding functionality dependent on beta features

Testing

  • Modified corresponding tests to exclude beta feature tests for vertex_ai_search.

Thank you Team,

@lgesuellip
Copy link
Contributor Author

Hey @lkuligin ,

I've added all the changes to support both the stable and beta versions of vertex_ai_search and updated the corresponding tests.

The changes turned out to be larger than expected.
Please let me know if you have any comments or suggestions.

Thanks!

@lgesuellip
Copy link
Contributor Author

@lkuligin ,

The integration tests are failing, but I’m unable to see the CI log details. Could you help me check?

Thanks so much!

@lgesuellip
Copy link
Contributor Author

@lkuligin

Please let me know if everything looks good or if there’s anything else needed.
Thank you!

“lgesuellip” added 2 commits December 27, 2024 17:58
@lgesuellip
Copy link
Contributor Author

@lkuligin Thank you for the feedback! All the changes pushed.

@lkuligin
Copy link
Collaborator

@lgesuellip thanks for the changes! some linting issues remain, take a look, please (probably it's enough just to ignore the warnings for now).

@lgesuellip
Copy link
Contributor Author

  • Removed unsupported v1beta features from VertexAISearchRetriever: embedding_spec, ranking_expression, relevance_threshold, personalization_spec, and natural_language_query_understanding_spec

@lkuligin I just updated it! Thanks,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants