fix: fix update external dataset error in dataset list (#11989)

langgenius · Dec 23, 2024 · 02a7ae1 · 02a7ae1
1 parent 74b1b60
commit 02a7ae1
Showing 1 changed file with 6 additions and 2 deletions.
diff --git a/api/services/dataset_service.py b/api/services/dataset_service.py
@@ -231,11 +231,15 @@ def update_dataset(dataset_id, data, user):
 
         DatasetService.check_dataset_permission(dataset, user)
         if dataset.provider == "external":
-            dataset.retrieval_model = data.get("external_retrieval_model", None)
+            external_retrieval_model = data.get("external_retrieval_model", None)
+            if external_retrieval_model:
+                dataset.retrieval_model = external_retrieval_model
             dataset.name = data.get("name", dataset.name)
             dataset.description = data.get("description", "")
+            permission = data.get("permission")
+            if permission:
+                dataset.permission = permission
             external_knowledge_id = data.get("external_knowledge_id", None)
-            dataset.permission = data.get("permission")
             db.session.add(dataset)
             if not external_knowledge_id:
                 raise ValueError("External knowledge id is required.")