Skip to content

Commit

Permalink
fix: refactor create_clusters function to use keyword arguments for c…
Browse files Browse the repository at this point in the history
…larity and maintainability

Signed-off-by: -LAN- <[email protected]>
  • Loading branch information
laipz8200 committed Dec 24, 2024
1 parent 6686b74 commit 1a9d127
Showing 1 changed file with 8 additions and 7 deletions.
15 changes: 8 additions & 7 deletions api/schedule/create_tidb_serverless_task.py
Original file line number Diff line number Diff line change
Expand Up @@ -36,14 +36,15 @@ def create_tidb_serverless_task():

def create_clusters(batch_size):
try:
# TODO: maybe we can set the default value for the following parameters in the config file
new_clusters = TidbService.batch_create_tidb_serverless_cluster(
batch_size,
dify_config.TIDB_PROJECT_ID or "",
dify_config.TIDB_API_URL or "",
dify_config.TIDB_IAM_API_URL or "",
dify_config.TIDB_PUBLIC_KEY or "",
dify_config.TIDB_PRIVATE_KEY or "",
dify_config.TIDB_REGION or "",
batch_size=batch_size,
project_id=dify_config.TIDB_PROJECT_ID or "",
api_url=dify_config.TIDB_API_URL or "",
iam_url=dify_config.TIDB_IAM_API_URL or "",
public_key=dify_config.TIDB_PUBLIC_KEY or "",
private_key=dify_config.TIDB_PRIVATE_KEY or "",
region=dify_config.TIDB_REGION or "",
)
for new_cluster in new_clusters:
tidb_auth_binding = TidbAuthBinding(
Expand Down

0 comments on commit 1a9d127

Please sign in to comment.