fix(node): correct conditional checks in list filter node

- Added check for variable value before type checking in ListFilterNode to prevent unnecessary errors. - Fixed incorrect workflow feature path in AppDslService to ensure correct data fetching.
langgenius · Sep 29, 2024 · d954e0e · d954e0e
1 parent 5ecc638
commit d954e0e
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/api/core/workflow/nodes/list_filter/node.py b/api/core/workflow/nodes/list_filter/node.py
@@ -27,7 +27,7 @@ def _run(self):
             return NodeRunResult(
                 status=WorkflowNodeExecutionStatus.FAILED, error=error_message, inputs=inputs, outputs=outputs
             )
-        if not isinstance(variable, ArrayFileSegment | ArrayNumberSegment | ArrayStringSegment):
+        if variable.value and not isinstance(variable, ArrayFileSegment | ArrayNumberSegment | ArrayStringSegment):
             error_message = (
                 f"Variable {node_data.variable} is not an ArrayFileSegment, ArrayNumberSegment " "or ArrayStringSegment"
             )

diff --git a/api/services/app_dsl_service.py b/api/services/app_dsl_service.py
@@ -265,7 +265,7 @@ def _import_and_create_new_workflow_based_app(
         draft_workflow = workflow_service.sync_draft_workflow(
             app_model=app,
             graph=workflow_data.get("graph", {}),
-            features=workflow_data.get("../core/app/features", {}),
+            features=workflow_data.get("features", {}),
             unique_hash=None,
             account=account,
             environment_variables=environment_variables,