-
Notifications
You must be signed in to change notification settings - Fork 7.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: bump minimum supported Python version to 3.11 #10386
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for doing this great work.
IMO, the updates for GitHub Actions, documentation, and code should be separated into three PRs. Would you mind making this change?
There’s no need to rush, as we still need to test the new Python version.
Thanks for the review. Python 3.11 brings performance improvements and many helpful features and typings. As for your suggestion of separated PR, it seems that we still have to put them in one.
|
I think it's better to keep support python3.10, due to the great cost of upgrading docker image(and other parts). |
@cuckootan We have to do this upgrade cause many new libraries require the new Python version. You can start preparing to do this upgrade from now on. |
e1a7aad
to
814c9fa
Compare
cbf7d23
to
4e52b21
Compare
Checklist:
Important
Please review the checklist below before submitting your pull request.
dev/reformat
(backend) andcd web && npx lint-staged
(frontend) to appease the lint godsDescription
dev/reformat
--unsafe-fixes
Type of Change
Testing Instructions
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration