Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): avoid reinstall pipx and pin poetry version aligned with in api dockerfile #10426

Merged
merged 14 commits into from
Nov 8, 2024

Conversation

bowenliang123
Copy link
Contributor

@bowenliang123 bowenliang123 commented Nov 7, 2024

Checklist:

Important

Please review the checklist below before submitting your pull request.

  • Please open an issue before creating a PR or link to an existing issue
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

Description

  • although pipx already shipped with runner image Ubuntu 24.04, install poetry directly on pip (not pipx) , with pip caching support
  • pin poetry version aligned with used in dockerfile

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update, included: Dify Document
  • Improvement, including but not limited to code refactoring, performance optimization, and UI/UX improvement
  • Dependency upgrade

Testing Instructions

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Nov 7, 2024
@bowenliang123 bowenliang123 changed the title chore(ci): install poetry from pipx for faster ci preperation and pin poetry version aligned with in api dockerfile chore(ci): install poetry with pipx for faster ci preperation and pin poetry version aligned with in api dockerfile Nov 7, 2024
@bowenliang123 bowenliang123 changed the title chore(ci): install poetry with pipx for faster ci preperation and pin poetry version aligned with in api dockerfile chore(ci): avoid reinstall pipx and pin poetry version aligned with in api dockerfile Nov 7, 2024
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. and removed size:S This PR changes 10-29 lines, ignoring generated files. labels Nov 7, 2024
@crazywoola crazywoola requested a review from laipz8200 November 8, 2024 09:07
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Nov 8, 2024
@crazywoola crazywoola merged commit 754bfb1 into langgenius:main Nov 8, 2024
10 checks passed
@bowenliang123 bowenliang123 deleted the pipx-poetry branch November 8, 2024 09:31
AlwaysBluer pushed a commit to AlwaysBluer/dify that referenced this pull request Nov 14, 2024
idonotknow pushed a commit to AceDataCloud/Dify that referenced this pull request Nov 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants