Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(http_request): send form data #10431

Merged
merged 2 commits into from
Nov 8, 2024
Merged

fix(http_request): send form data #10431

merged 2 commits into from
Nov 8, 2024

Conversation

laipz8200
Copy link
Member

Checklist:

Important

Please review the checklist below before submitting your pull request.

  • Please open an issue before creating a PR or link to an existing issue
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

Description

Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue. Close issue syntax: Fixes #<issue number>, see documentation for more details.

Fixes #10362

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update, included: Dify Document
  • Improvement, including but not limited to code refactoring, performance optimization, and UI/UX improvement
  • Dependency upgrade

Testing Instructions

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. 🐞 bug Something isn't working labels Nov 7, 2024
@laipz8200 laipz8200 requested a review from crazywoola November 7, 2024 18:02
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. and removed size:L This PR changes 100-499 lines, ignoring generated files. labels Nov 7, 2024
@bowenliang123
Copy link
Contributor

It's quite shocking for me to see sending the POST requests by manual raw HTTP request body assembly in http_request/executor. Too many details to handle in place, from deciding boundary separator in this case of form data way , to encoding details in form-urlencoded way.

I would try all my best to ensure the requests are executed on higher API for better maintenance and ease of use.

@laipz8200
Copy link
Member Author

The log method is just used to simulate HTTP raw for displaying logs. In reality, the request is completed using httpx.

@bowenliang123
Copy link
Contributor

Yes, well noticed.

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Nov 8, 2024
@crazywoola crazywoola merged commit 438ad81 into main Nov 8, 2024
9 checks passed
@crazywoola crazywoola deleted the fix/send-form-data branch November 8, 2024 01:33
laipz8200 added a commit that referenced this pull request Nov 8, 2024
AlwaysBluer pushed a commit to AlwaysBluer/dify that referenced this pull request Nov 14, 2024
idonotknow pushed a commit to AceDataCloud/Dify that referenced this pull request Nov 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The HTTP request node failed to send form-data parameters
3 participants