Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed the Base URL usage issue in Podcast Generator tool verification #10697

Merged
merged 1 commit into from
Nov 14, 2024
Merged

fixed the Base URL usage issue in Podcast Generator tool verification #10697

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions api/core/tools/provider/builtin/podcast_generator/podcast_generator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
from typing import Any

import openai
from yarl import URL

from core.tools.errors import ToolProviderCredentialValidationError
from core.tools.provider.builtin_tool_provider import BuiltinToolProviderController
Expand All @@ -10,20 +11,24 @@ class PodcastGeneratorProvider(BuiltinToolProviderController):
def _validate_credentials(self, credentials: dict[str, Any]) -> None:
tts_service = credentials.get("tts_service")
api_key = credentials.get("api_key")
base_url = credentials.get("openai_base_url")

if not tts_service:
raise ToolProviderCredentialValidationError("TTS service is not specified")

if not api_key:
raise ToolProviderCredentialValidationError("API key is missing")

if base_url:
base_url = str(URL(base_url) / "v1")

if tts_service == "openai":
self._validate_openai_credentials(api_key)
self._validate_openai_credentials(api_key, base_url)
else:
raise ToolProviderCredentialValidationError(f"Unsupported TTS service: {tts_service}")

def _validate_openai_credentials(self, api_key: str) -> None:
client = openai.OpenAI(api_key=api_key)
def _validate_openai_credentials(self, api_key: str, base_url: str | None) -> None:
client = openai.OpenAI(api_key=api_key, base_url=base_url)
try:
# We're using a simple API call to validate the credentials
client.models.list()
Expand Down