Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: create_blob_message of tool will always create image type file #10701

Merged
merged 3 commits into from
Nov 15, 2024

Conversation

hjlarry
Copy link
Contributor

@hjlarry hjlarry commented Nov 14, 2024

Summary

Tip

Close issue syntax: Fixes #<issue number> or Resolves #<issue number>, see documentation for more details.

Now there are some tools can generate video/audio format of files, but the create_blob_message API of tool will always generate image file type, so the speech2text tool will validate the file type may raise error.

Screenshots

Before After
0dec07d974ca93c6c64b661afcca000f cf44963a2455f2f297320cb130c7d281

Checklist

Important

Please review the checklist below before submitting your pull request.

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. 🐞 bug Something isn't working labels Nov 14, 2024
@crazywoola crazywoola requested a review from laipz8200 November 14, 2024 12:56
Copy link
Member

@laipz8200 laipz8200 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I’d prefer if you could make get_file_type_by_mimetype a private function within the file_factory module and use it in _build_from_tool_file whenever the type isn’t available. You can get the file’s mime-type from tool_file.mimetype.

After that, we can remove the need to pass in the type.

@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. and removed size:M This PR changes 30-99 lines, ignoring generated files. labels Nov 15, 2024
@hjlarry
Copy link
Contributor Author

hjlarry commented Nov 15, 2024

I’d prefer if you could make get_file_type_by_mimetype a private function within the file_factory module and use it in _build_from_tool_file whenever the type isn’t available. You can get the file’s mime-type from tool_file.mimetype.

After that, we can remove the need to pass in the type.

Good Idea! I also removed some unused local variable, please review again.

@hjlarry hjlarry requested a review from laipz8200 November 15, 2024 02:03
Copy link
Member

@laipz8200 laipz8200 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Thank you for your contribution~

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Nov 15, 2024
@laipz8200 laipz8200 merged commit 4b2abf8 into langgenius:main Nov 15, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants