Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix weight rerank of knowledge retrieval #10931

Merged
merged 2 commits into from
Nov 21, 2024
Merged

fix weight rerank of knowledge retrieval #10931

merged 2 commits into from
Nov 21, 2024

Conversation

AkisAya
Copy link
Contributor

@AkisAya AkisAya commented Nov 21, 2024

Summary

fixes #10930

Tip

Close issue syntax: Fixes #<issue number> or Resolves #<issue number>, see documentation for more details.

Screenshots

Before: After:
... ...

Checklist

Important

Please review the checklist below before submitting your pull request.

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Nov 21, 2024
@crazywoola
Copy link
Member

@yihong0618 Can you take a look as well.

yihong0618
yihong0618 approved these changes Nov 21, 2024
View reviewed changes
Copy link
Contributor

@yihong0618 yihong0618 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
thanks for the change.

@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. and removed size:XS This PR changes 0-9 lines, ignoring generated files. labels Nov 21, 2024
@crazywoola
Copy link
Member

@AkisAya @yihong0618 Can you guys add my wechat. We have a wechat groups for contributors. :)

@crazywoola crazywoola mentioned this pull request Nov 21, 2024
Closed
5 tasks
@AkisAya
Copy link
Contributor Author

AkisAya commented Nov 21, 2024

@AkisAya @yihong0618 Can you guys add my wechat. We have a wechat groups for contributors. :)

ok，how to get your wechat num

@crazywoola
Copy link
Member

crazyphage @AkisAya

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Nov 21, 2024
@crazywoola crazywoola merged commit cb0c55d into langgenius:main Nov 21, 2024
6 checks passed
@AkisAya
Copy link
Contributor Author

AkisAya commented Nov 21, 2024

crazyphage @AkisAya
applied

aconeshana pushed a commit to aconeshana/dify that referenced this pull request Nov 21, 2024
@AkisAya
fix weight rerank of knowledge retrieval (langgenius#10931)
cee4643
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bowenliang123 bowenliang123 bowenliang123 approved these changes

@crazywoola crazywoola crazywoola approved these changes

@yihong0618 yihong0618 yihong0618 approved these changes

@JohnJyong JohnJyong Awaiting requested review from JohnJyong

Assignees
No one assigned
Labels
lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

weight rerank not working properly in knowledge retrieval
4 participants
@AkisAya @crazywoola @bowenliang123 @yihong0618