Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing #11005: Incorrect max_tokens in yaml file for AWS Bedrock US Cross Region Inference version of 3.5 Sonnet v2 and 3.5 Haiku #11013

Merged
merged 1 commit into from
Nov 23, 2024

Conversation

kazuhisa-wada
Copy link
Contributor

@kazuhisa-wada kazuhisa-wada commented Nov 23, 2024

Summary

This PR Fixes #11005 .
This is to fix maximum number of configurable Max Tokens on model configuration UI for the case: bedrock claude 3.5 sonnet v2 cross region and claude 3.5 haiku cross region.

Those number right now is 4096, To-Be is 8192.

Screenshots

Before:

image

image

After:

image

image

... ...

Checklist

Important

Please review the checklist below before submitting your pull request.

NA as this is just to change the yaml file for UI displaying.
As clarified in previous section, yaml fixes where reflected to UI expectedly where I confirmed chat application worked as expected for both of Cross Region bedrock claude 3.5 sonnet v2 cross region/cladue 3.5 haiku cross region.

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. ⚙️ feat:model-runtime labels Nov 23, 2024
@kazuhisa-wada kazuhisa-wada changed the title Fixing ##11005: Incorrect max_tokens in yaml file for AWS Bedrock US Cross Region Inference version of 3.5 Sonnet v2 and 3.5 Haiku Fixing #11005: Incorrect max_tokens in yaml file for AWS Bedrock US Cross Region Inference version of 3.5 Sonnet v2 and 3.5 Haiku Nov 23, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Nov 23, 2024
@crazywoola crazywoola merged commit 16c4158 into langgenius:main Nov 23, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⚙️ feat:model-runtime lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
2 participants