Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: better path trigger for vdb and fix the version #11057

Merged
merged 1 commit into from
Nov 25, 2024
Merged

fix: better path trigger for vdb and fix the version #11057

merged 1 commit into from
Nov 25, 2024
+4 −2

Conversation

yihong0618
Copy link
Contributor

Summary

refer to #11056 (comment)

Tip

Close issue syntax: Fixes #<issue number> or Resolves #<issue number>, see documentation for more details.

Screenshots

Before: After:
... ...

Checklist

Important

Please review the checklist below before submitting your pull request.

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Nov 25, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Nov 25, 2024
@laipz8200 laipz8200 merged commit 04b9a2c into langgenius:main Nov 25, 2024
7 checks passed
@yihong0618 yihong0618 mentioned this pull request Nov 25, 2024
Merged
bowenliang123
bowenliang123 reviewed Nov 25, 2024
View reviewed changes
Copy link
Contributor

@bowenliang123 bowenliang123 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A late LGTM. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bowenliang123 bowenliang123 bowenliang123 left review comments

@laipz8200 laipz8200 laipz8200 approved these changes

Assignees
No one assigned
Labels
lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yihong0618 @bowenliang123 @laipz8200