Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync INDEXING_MAX_SEGMENTATION_TOKENS_LENGTH between API and Web #11230

Merged

Conversation

fujita-h
Copy link
Contributor

Summary

  • Changed the INDEXING_MAX_SEGMENTATION_TOKENS_LENGTH setting to reflect the web side.
  • Changed the default value of INDEXING_MAX_SEGMENTATION_TOKENS_LENGTH from 1000 to 4000.

Fixes: #11229

Checklist

Important

Please review the checklist below before submitting your pull request.

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. ☕️ typescript Pull request that update TypeScript code. labels Nov 30, 2024
@crazywoola crazywoola requested a review from JohnJyong November 30, 2024 09:28
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Nov 30, 2024
@crazywoola crazywoola merged commit 1d8385f into langgenius:main Dec 2, 2024
8 checks passed
@fujita-h fujita-h deleted the fix-rag-indexing-max-seg-token-length branch December 2, 2024 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files. ☕️ typescript Pull request that update TypeScript code.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The maximum number of segmentation tokens in a dataset was not consistent between api and web.
3 participants