Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: claude can not handle empty string #11238

Merged

Conversation

yihong0618
Copy link
Contributor

@yihong0618 yihong0618 commented Dec 1, 2024

Summary

This patch try to fix claude api can not handle empty string problem.
close #9366
close #10013
close #10520.

more: info -> we can check others face the problem

dspinellis/ai-cli-lib@0ddcaac
dspinellis/ai-cli-lib#16

karthink/gptel@8b129c5#diff-17f2ed0388d8bb8379b05dd47711d80f6b44463ff782876fc7084ae1df090fe6R97
karthink/gptel#409

as a refer that fix it.

Tip

Close issue syntax: Fixes #<issue number> or Resolves #<issue number>, see documentation for more details.

Screenshots

Before: After:
... ...

Checklist

Important

Please review the checklist below before submitting your pull request.

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. 🐞 bug Something isn't working labels Dec 1, 2024
Copy link
Member

@crazywoola crazywoola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Dec 2, 2024
@laipz8200 laipz8200 merged commit 02572e8 into langgenius:main Dec 2, 2024
5 checks passed
@laipz8200
Copy link
Member

Thanks.

Maybe we should add some validation logic in the PromptMessage model.

@yihong0618
Copy link
Contributor Author

Thanks.

Maybe we should add some validation logic in the PromptMessage model.

did some search seems only claude had this problem for now, and I am not quite sure it fixed, waiting for the user reponse.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
3 participants