-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FIX: Retrieval top n bug #11305
FIX: Retrieval top n bug #11305
Conversation
Actually, I think we should find a better way to implement this feature. In the implementation of this PR, if we set the environment variable, the settings we set in the web view will not work. |
First of all, I apologize to your team for my mistake, but this temporary solution seems to work in my project, and I also agree with @nadirvishun ‘s opinion of view. Does diffy have any plans to introduce the top_n parameter on the page side? |
a1a0acd
to
7e8922b
Compare
7e8922b
to
8c5254a
Compare
8c5254a
to
5185ed7
Compare
I've pinged our team to review this feature request, let's discuss #11068. |
We believe this feature is not essential. Please refer to #11068 (comment). |
Summary
Sorry, I made a stupid mistake and caused a bad impact on your, this is the revised submission
Close #11300
Close #11068
Screenshots
Checklist
Important
Please review the checklist below before submitting your pull request.
dev/reformat
(backend) andcd web && npx lint-staged
(frontend) to appease the lint gods