Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat] Add AWS Bedrock rerank #11349

Merged
merged 10 commits into from
Dec 5, 2024
Merged

[feat] Add AWS Bedrock rerank #11349

merged 10 commits into from
Dec 5, 2024

Conversation

warren830
Copy link
Contributor

Summary

This pr adds AWS Bedrock rerank.

Tip

Close issue syntax: Fixes #<issue number> or Resolves #<issue number>, see documentation for more details.

Screenshots

we can choose rerank model:
image

And here we can successfully retrieve documents:
image

Checklist

Important

Please review the checklist below before submitting your pull request.

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. ⚙️ feat:model-runtime labels Dec 4, 2024
crazywoola
crazywoola previously approved these changes Dec 4, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Dec 4, 2024
@crazywoola
Copy link
Member

cc @Yeuoly @laipz8200

@warren830
Copy link
Contributor Author

@crazywoola sorry, can you approve again

@crazywoola
Copy link
Member

Still failed to pass the lint.

@warren830
Copy link
Contributor Author

Sorry man@crazywoola , this time I used ruff to make sure:
image

@crazywoola crazywoola merged commit 376726c into langgenius:main Dec 5, 2024
7 checks passed
iamjoel pushed a commit that referenced this pull request Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⚙️ feat:model-runtime lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants